Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(compute/serve): check for missing override_host #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Integralist merged 2 commits into from
Feb 21, 2023
Merged

fix(compute/serve): check for missing override_host #832

Integralist merged 2 commits into from
Feb 21, 2023

Conversation

@Integralist
Copy link
Collaborator

@Integralist Integralist commented Feb 21, 2023 •
edited
Loading

Add an INFO log message to the --verbose output indicating whether any defined local_server.backends are missing the override_host property, as this can cause confusing errors.

$ fastly compute serve --verbose

Fastly API token provided via FASTLY_API_TOKEN
Fastly API endpoint: https://api.fastly.com

INFO: One of the project's `local_server.backends` has a backend configured
without an `override_host` and in some cases can result in unexpected errors. See
https://developer.fastly.com/reference/compute/fastly-toml/#local-server for more details.

Running local server...
Wasm file: bin/main.wasm
Manifest: /Users/integralist/Code/test-projects/testing-fastly-cli/fastly.toml

2023-02-21T10:41:19.545494Z  INFO checking if backend 'backend_a' is up
2023-02-21T10:41:19.546455Z  WARN backend 'backend_a' on 'http://127.0.0.1/' is not up right now
2023-02-21T10:41:19.546550Z  INFO Listening on http://127.0.0.1:7676

@Integralist Integralist added the enhancement New feature or request label Feb 21, 2023
@Integralist Integralist merged commit 1cdaf97 into main Feb 21, 2023
@Integralist Integralist deleted the integralist/override-host-missing branch February 21, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JakeChampion JakeChampion JakeChampion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Integralist @JakeChampion