Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Integralist
Copy link
Collaborator

@Integralist Integralist commented Feb 22, 2023

I've experienced numerous bugs and rendering issues related to our custom text.Progress and so I started to replace its usage in the compute commands and this PR is finishing the work by replacing its usage across the entire CLI code base.

I also took the opportunity to fix a bunch of rendering issues as part of this PR.

NOTE: The new spinner interface is more verbose but its explicitness actually helps to identify errors and buggy logic flows (as I discovered while running the CLI test suite). I intend on opening a separate PR to try and refactor out (if I can) this verboseness behind some kind of abstraction.

@Integralist Integralist added the enhancement New feature or request label Feb 22, 2023
@Integralist Integralist merged commit c803ff7 into main Feb 22, 2023
@Integralist Integralist deleted the integralist/new-spinner branch February 22, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants