Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(compute/serve): make override_host a default behaviour #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Integralist merged 1 commit into from
Feb 23, 2023
Merged

fix(compute/serve): make override_host a default behaviour #843

Integralist merged 1 commit into from
Feb 23, 2023

Conversation

@Integralist
Copy link
Collaborator

@Integralist Integralist commented Feb 23, 2023 •
edited
Loading

With the following configuration:

[local_server]
[local_server.backends]
[local_server.backends.backend_a]
url = "http://127.0.0.1/"
[local_server.backends.backend_b]
url = "https://example.org/"
[local_server.backends.backend_c]
url = "http://127.0.0.1:8080/"

Although none of these backends set an override_host only backend_b will get set as a default (one that matches the domain's host) as the other two are IPs and a backend should ignore any Host header.

We now see (notice we only get an INFO log if we use --verbose mode)...

Screenshot 2023-02-23 at 15 59 24

@Integralist Integralist added the enhancement New feature or request label Feb 23, 2023
@Integralist Integralist force-pushed the integralist/move-info-to-default branch from 9042fa9 to 069f7f2 Compare February 23, 2023 15:27
@Integralist Integralist force-pushed the integralist/move-info-to-default branch from 069f7f2 to 49daef3 Compare February 23, 2023 16:00
@Integralist Integralist merged commit 923b809 into main Feb 23, 2023
@Integralist Integralist deleted the integralist/move-info-to-default branch February 23, 2023 17:27
@harmony7 harmony7 mentioned this pull request Mar 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Integralist