Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(dict/create): display dictionary ID on creation #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Integralist merged 1 commit into from
Mar 1, 2023
Merged

feat(dict/create): display dictionary ID on creation #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/commands/dictionary/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,6 @@ func (c *CreateCommand) Exec(_ io.Reader, out io.Writer) error {
writeOnlyOutput = "as write-only "
}

text.Success(out, "Created dictionary %s %s(service %s version %d)", d.Name, writeOnlyOutput, d.ServiceID, d.ServiceVersion)
text.Success(out, "Created dictionary %s %s(id %s, service %s, version %d)", d.Name, writeOnlyOutput, d.ID, d.ServiceID, d.ServiceVersion)
return nil
}
4 changes: 2 additions & 2 deletions pkg/commands/dictionary/dictionary_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,8 +454,8 @@ var (
)

var (
createDictionaryOutput = "\nSUCCESS: Created dictionary denylist (service 123 version 4)\n"
createDictionaryOutputWriteOnly = "\nSUCCESS: Created dictionary denylist as write-only (service 123 version 4)\n"
createDictionaryOutput = "\nSUCCESS: Created dictionary denylist (id 456, service 123, version 4)\n"
createDictionaryOutputWriteOnly = "\nSUCCESS: Created dictionary denylist as write-only (id 456, service 123, version 4)\n"
deleteDictionaryOutput = "\nSUCCESS: Deleted dictionary allowlist (service 123 version 4)\n"
updateDictionaryOutput = "\nSUCCESS: Updated dictionary oldname (service 123 version 4)\n"
updateDictionaryNameOutput = "\nSUCCESS: Updated dictionary dict-1 (service 123 version 4)\n"
Expand Down