Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Integralist
Copy link
Collaborator

A customer reported the following error...

✗ Fetching latest Viceroy release

ERROR: error downloading latest Viceroy release: failed to download release asset: context deadline exceeded (Client.Timeout or context cancellation while reading body).

This is a confusing error because the message "failed to download" suggests the error is related to the request to the API endpoint timed out, when in fact this error happens when the response body is being read.

So this PR addresses two things...

  1. It updates the error message to be clearer.
  2. It updates the http.Client.Timeout setting to be longer (†).

† Refer to the below image which shows the timeout includes all stages up to reading the body.

@Integralist Integralist added the bug Something isn't working label Mar 15, 2023
@Integralist Integralist merged commit 5b7155a into main Mar 15, 2023
@Integralist Integralist deleted the integralist/fix-timeout-confusion branch March 15, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants