Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(compute/serve): always display local server address #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Integralist merged 1 commit into from
Mar 20, 2023
Merged

fix(compute/serve): always display local server address #879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions pkg/commands/compute/serve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,13 +245,6 @@ func GetViceroy(

bin = filepath.Join(InstallDir, av.BinaryName())

defer func() {
if g.Verbose() {
text.Info(out, "Using Viceroy from: %s", bin)
text.Break(out)
}
}()

// NOTE: When checking if Viceroy is installed we don't use
// exec.LookPath("viceroy") because PATH is unreliable across OS platforms,
// but also we actually install Viceroy in the same location as the
Expand Down Expand Up @@ -589,9 +582,14 @@ func local(bin, file, addr, env string, debug, watch bool, watchDir cmd.Optional

if verbose {
text.Break(out)
text.Output(out, "Wasm file: %s", file)
text.Output(out, "Manifest: %s", manifestPath)
text.Output(out, "%s: %s", text.BoldYellow("Manifest"), manifestPath)
text.Output(out, "%s: %s", text.BoldYellow("Wasm binary"), file)
text.Output(out, "%s:\n%s", text.BoldYellow("Viceroy binary"), bin)
args = append(args, "-v")
} else {
// IMPORTANT: Viceroy 0.4.0 changed its INFO log output behind a -v flag.
// We display the address unless in verbose mode to avoid duplicate output.
text.Info(out, "Listening on http://%s", addr)
}

s := &fstexec.Streaming{
Expand Down