breaking(objectstore): rename object-store command to kv-store
#904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
reviewed
Apr 12, 2023
Collaborator
Integralist
left a comment
There was a problem hiding this comment.
LGTM. Only a couple of minor change requests.
Co-authored-by: Mark McDonnell <[email protected]>
Integralist
approved these changes
Apr 12, 2023
Collaborator
Integralist
left a comment
There was a problem hiding this comment.
LGTM. Will merge once CI is finished (and passing).
object-store command to kv-store
| } | ||
|
|
||
| func constructSetupObjects( | ||
| func constructSetupKVs( |
Collaborator
There was a problem hiding this comment.
Wondering if this should have been left as constructSetupObjects? Since setup.Backends, for example, aren't key-value stores. Working through merge conflicts in #769 and noticed this.
Collaborator
There was a problem hiding this comment.
@awilliams-fastly correct! I'm actually fixing this at the moment 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are renaming object store to kv store so doing the needed changes here.
Blocked by: fastly/go-fastly#422