fix(errors/log): support filtering errors to Sentry #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behaviour is now reversed. We no longer default to sending all errors to Sentry. Instead, for each error report, we must opt-in to sending the error to Sentry. This is because the majority of errors instrumented are Fastly API errors and these are not actionable as far as the Fastly CLI is concerned.
5986bb8 to
3260ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: reporting Fastly API errors to Sentry exhausts service limits.
Solution: only report errors that are actual Fastly CLI logic bugs (as those are actionable errors).
Note: the primary affected file is
pkg/errors/log.goas that filters out errors before sending to Sentry.