-
Notifications
You must be signed in to change notification settings - Fork 70
feat(kvstore): Bulk Import #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The reason for the temp commit is that this work highlighted possible performance concerns and so we'll want to rewrite this to avoid using the batch API endpoint.
3f325aa to
a311ecc
Compare
fc89164 to
81d37d4
Compare
81d37d4 to
1cc2579
Compare
|
@awilliams-fastly This is draft for the moment just while I wait for the batch API endpoint to be documented on https://developer.fastly.com/reference/api/ (there is an internal PR for that work). Once it's documented, then I can look to implement the endpoint in the go-fastly API client, and once in a published release I can replace the But for the time being, you might be able to assist with a quick review. Thanks! |
5f527e6 to
eb79c00
Compare
awilliams-fastly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There's just a the few remaining comments, but the overall change looks good.
|
Thanks @awilliams-fastly I think I just need to write some tests for the new bulk import logic and then I'm done. |
348470b to
4a45932
Compare
eda545d to
35e1356
Compare
Was unable to get checking the attributes of a file to work on Windows platform in the CI environment.
35e1356 to
2233c11
Compare
48e68e9 to
2442257
Compare
This PR introduces both breaking changes and the following features for bulk importing data into the Fastly KV Store.
The breaking changes introduced in this PR are the rename of the
--key-nameflag to--keyto be consistent with the other 'stores' supported within the CLI.Each example is documented in
pkg/app/metadata.json.Screenshots
Example of successful insertion:
Example of failed insertion: