secret store: Add --recreate and --recreate-must options #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Integralist
reviewed
May 11, 2023
| Required: false, | ||
| }) | ||
| c.RegisterFlagBool(cmd.BoolFlagOpts{ | ||
| Name: "recreate-must", |
Collaborator
There was a problem hiding this comment.
I'm not really a fan of the naming of these flags because of the overloaded nature of the first one.
To me "recreate" means the thing exists and I want it to be recreated. The fact that it will internally behave like a "create", if by chance I happen to have misspelt the name, is more of an unexpected side-effect I think.
It makes recreate-must a bit confusing.
I wonder if we rename recreate to recreate-allowed and recreate-must to recreate, like so...
fastly secrets-store-entry create
# Create secret but error if secret name already exists (i.e. POST)
# e.g. I think the secret doesn't exist, so I'm OK getting an error back telling me it does
fastly secrets-store-entry create --recreate
# Recreate secret but error if secret name doesn't already exists (i.e. PATCH)
# e.g. I think the secret already exists, so I explicitly state my expectation is a recreate.
fastly secrets-store-entry create --recreate-allowed
# Create or Recreate secret (i.e. PUT)
# e.g. I don't know if the secret already exists, so I'm saying "allow a replacement to happen"
Collaborator
Author
There was a problem hiding this comment.
I've made your suggested change in 263ef62
This works in combination with fastly/go-fastly#433 which adds support for the `CreateSecretInput.Method` field. Secret names must be unique within a store. The method effects how duplicate names are handled: - `POST`: Default. Create a secret; error if one already exists with the same name. - `PUT` / `--recreate`: Create or recreate a secret. - `PATCH` / `--recreate-must`: Recreate a secret and error if one does not already exist with the same name.
070c438 to
31a3f35
Compare
Integralist
reviewed
May 26, 2023
| wantError: "unable to read from STDIN", | ||
| }, | ||
| { | ||
| args: fmt.Sprintf("create --store-id %s --name %s --stdin --recreate --recreate-must", storeID, secretName), |
Collaborator
There was a problem hiding this comment.
I think this test is referencing the old flag name and I expect CI to fail.
Integralist
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works in combination with fastly/go-fastly#433 which adds support for the
CreateSecretInput.Methodfield.Secret names must be unique within a store.
The method effects how duplicate names are handled:
POST: Default. Create a secret; error if one already exists with the same name.PUT/--recreate-allow: Create or recreate a secret.PATCH/--recreate: Recreate a secret and error if one does not already exist with the same name.DRAFT until fastly/go-fastly#433 is merged and a new release is created.