Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fastly backend create: override host cannot be an empty string #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Integralist merged 4 commits into from
May 16, 2023
Merged

fastly backend create: override host cannot be an empty string #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c43906
test that demostrates we set a default empty string as override host …
dcaba May 16, 2023
59bdf81
dirty patch to ensure we are not setting empty strings if there is no…
dcaba May 16, 2023
f94d40d
Update pkg/commands/backend/backend_test.go
Integralist May 16, 2023
0fccdb0
Update pkg/commands/backend/backend_test.go
Integralist May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion pkg/commands/backend/backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,16 @@ func TestBackendCreate(t *testing.T) {
},
WantOutput: "Created backend www.test.com (service 123 version 4)",
},
// We test that setting an invalid host override does not result in an error
{
Args: args("backend create --service-id 123 --version 1 --address 127.0.0.1 --override-host invalid-host-override --name www.test.com --autoclone --port 8080"),
API: mock.API{
ListVersionsFn: testutil.ListVersions,
CloneVersionFn: testutil.CloneVersionResult(4),
CreateBackendFn: createBackendWithPort(8080),
},
WantOutput: "Created backend www.test.com (service 123 version 4)",
},
// The following test validates that --service-name can replace --service-id
{
Args: args("backend create --service-name Foo --version 1 --address 127.0.0.1 --name www.test.com --autoclone"),
Expand Down Expand Up @@ -346,7 +356,8 @@ func createBackendError(i *fastly.CreateBackendInput) (*fastly.Backend, error) {
func createBackendWithPort(wantPort int) func(*fastly.CreateBackendInput) (*fastly.Backend, error) {
return func(i *fastly.CreateBackendInput) (*fastly.Backend, error) {
switch {
case i.Port != nil && *i.Port == wantPort:
// if overridehost is set, should be a non "" value
case i.Port != nil && *i.Port == wantPort && ((i.OverrideHost == nil) || (i.OverrideHost != nil && *i.OverrideHost != "")):
return createBackendOK(i)
default:
return createBackendError(i)
Expand Down
4 changes: 3 additions & 1 deletion pkg/commands/backend/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,9 @@ func (c *CreateCommand) Exec(_ io.Reader, out io.Writer) error {

if input.Address != nil && !c.overrideHost.WasSet && !c.sslCertHostname.WasSet && !c.sslSNIHostname.WasSet {
overrideHost, sslSNIHostname, sslCertHostname := SetBackendHostDefaults(*input.Address)
input.OverrideHost = &overrideHost
if overrideHost != "" {
input.OverrideHost = &overrideHost
}
input.SSLSNIHostname = &sslSNIHostname
input.SSLCertHostname = &sslCertHostname
} else {
Expand Down