feat(compute/hashfiles): add hash-files subcommand #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgsch
reviewed
May 18, 2023
Comment on lines
+39
to
+43
| if !c.Globals.Flags.Quiet { | ||
| text.Warning(out, "This command is deprecated. Use `fastly compute hash-files` instead.") | ||
| text.Break(out) | ||
| } | ||
|
|
fgsch
reviewed
May 18, 2023
pkg/commands/compute/hashfiles.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| maxPackageSize = 100000000 // 100MB in bytes |
Member
There was a problem hiding this comment.
Q: any specific reason for this number?
fgsch
approved these changes
May 18, 2023
Member
fgsch
left a comment
There was a problem hiding this comment.
Untested but code LGTM.
Thanks for taking this to the end of the line 🙏
534d479 to
b3a4d0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
compute hashsumcommand in favour ofcompute hash-fileswhich aligns with the newhash_filesmetadata property exposed by the Fastly Package API endpoint.