Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(compute): clean-up logic surrounding filesHash generation #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Integralist merged 5 commits into from
Jul 5, 2023
Merged

refactor(compute): clean-up logic surrounding filesHash generation #969

Integralist merged 5 commits into from
Jul 5, 2023

Conversation

@fgsch
Copy link
Member

@fgsch fgsch commented Jul 5, 2023 •
edited
Loading

This is mostly a cleanup up from #967, reorganising things a bit.

fgsch added 2 commits July 5, 2023 01:27
@fgsch
Remove dead code
f562cea 
Leftovers from b451716.
@fgsch
Reorganise
dbbd05c 
Move files hash calculation out of validatePackage and closer to
where it is used.
@fgsch fgsch changed the title Follow up Follow up from #967 Jul 5, 2023
@fgsch fgsch marked this pull request as ready for review July 5, 2023 01:47
@fgsch fgsch force-pushed the fgsch/follow-up branch 3 times, most recently from d20c4a6 to 041207f Compare July 5, 2023 01:56
fgsch added 2 commits July 5, 2023 02:59
@fgsch
More reorganisation
8f87a62 
Add a new function to validate the package content, and convert
validate() into an iterator over the package content.
@fgsch
Update comment and variable name
3cfd61f
@fgsch fgsch force-pushed the fgsch/follow-up branch from 041207f to 3cfd61f Compare July 5, 2023 02:00
@fgsch fgsch requested a review from Integralist July 5, 2023 10:02
@Integralist Integralist changed the title Follow up from #967 refactor(compute): clean-up logic surrounding filesHash generation Jul 5, 2023
@Integralist Integralist merged commit 9866efa into main Jul 5, 2023
@Integralist Integralist deleted the fgsch/follow-up branch July 5, 2023 10:21
@Integralist Integralist added the clean-up Code clean-up or refactor label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Integralist Integralist Awaiting requested review from Integralist

Assignees

No one assigned

Labels

clean-up Code clean-up or refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fgsch @Integralist