Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kellymclaughlin
Copy link
Contributor

No description provided.

@kellymclaughlin
Copy link
Contributor Author

Will mark this ready for review after the next go-fastly version is tagged and I update the dependency to use that tag.

@Integralist
Copy link
Collaborator

@kellymclaughlin kellymclaughlin force-pushed the kellym/newrelic-otlp-logging-support branch from 2eced2c to a50e1fa Compare August 7, 2023 17:30
@kellymclaughlin kellymclaughlin marked this pull request as ready for review August 7, 2023 17:47
@kellymclaughlin
Copy link
Contributor Author

Looks like this PR is getting the same failure as this PR that just bumps the go-fastly version.

@Integralist
Copy link
Collaborator

👋🏻 ErrorThreshold was recently removed from go-fastly so it needs to be removed from the tests.

@Integralist
Copy link
Collaborator

@kellymclaughlin looks like this PR has gone stale.

@kellymclaughlin kellymclaughlin force-pushed the kellym/newrelic-otlp-logging-support branch from a50e1fa to d104145 Compare August 18, 2023 15:09
@kellymclaughlin
Copy link
Contributor Author

@Integralist Thanks for the heads up. I've rebased the branch and it looks like all the tests are happy now.

@Integralist Integralist merged commit 3e34dac into fastly:main Aug 18, 2023
@Integralist Integralist added the enhancement New feature or request label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants