-
Notifications
You must be signed in to change notification settings - Fork 70
Add support for the guest profiler under Viceroy #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4c15c09 to
013dfc7
Compare
pkg/commands/compute/serve.go
Outdated
| c.CmdClause.Flag("language", "Language type").Action(c.lang.Set).StringVar(&c.lang.Value) | ||
| c.CmdClause.Flag("package-name", "Package name").Action(c.packageName.Set).StringVar(&c.packageName.Value) | ||
| c.CmdClause.Flag("skip-build", "Skip the build step").BoolVar(&c.skipBuild) | ||
| c.CmdClause.Flag("profile-guest", "Profile the Wasm guest under Viceroy. More info at https://profiler.firefox.com/.").BoolVar(&c.profileGuest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viceroy displays "View this profile at https://profiler.firefox.com/`.
Maybe using View profiles at https://profiler.firefox.com/ is better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we sort the flags alphabetically as well while you're here 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
|
Output: and: |
013dfc7 to
a75a18e
Compare
Should address feedback by @Integralist.
Fixes #1018.