Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@joeshaw
Copy link
Member

@joeshaw joeshaw commented Sep 14, 2023

No description provided.

Copy link
Member

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll leave this for someone who actually works on this code.

Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're going to need to also bump the config_version inside of the .fastly/config.toml (which is merged with the output of this script to produce the final config.toml that's embedded into the CLI -- https://github.com/fastly/cli/blob/main/DEVELOP.md#fastlyconfigtoml).

If we don't bump the version, then the CLI will just end up using the config file already on the user's machine.

Where as bumping the version causes this line to get executed when the user invokes a CLI command (as the config has to be loaded when using the CLI): https://github.com/fastly/cli/blob/main/pkg/config/config.go#L325-L335.

@Integralist Integralist merged commit 22bd9df into main Sep 18, 2023
@Integralist Integralist deleted the joeshaw/tinygo-starter-kit branch September 18, 2023 17:06
@Integralist Integralist added the enhancement New feature or request label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants