feat(compute): add metadata subcommand
#1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3420dad to
a516765
Compare
Collaborator
Author
|
I've converted this PR to draft until we've had time to agree on what the 'default' behaviour is going to be and also the sequencing of events to the rollout of this feature. |
2cdf8ae to
db01ef9
Compare
compute metadata command
compute metadata commandcompute metadata command
compute metadata commandmetadata subcommand
joeshaw
reviewed
Sep 29, 2023
Member
joeshaw
left a comment
There was a problem hiding this comment.
LGTM except for the FIXME for the URL. One suggestion below if you like it.
0deae51 to
de810cb
Compare
Collaborator
Author
|
@joeshaw PR has been amended as per your feedback. The new output will look something like... |
e8e6f65 to
502108b
Compare
Member
|
Thanks. LGTM other than the FIXME. |
joeshaw
approved these changes
Oct 2, 2023
3f8a4de to
b2e7a99
Compare
62d3487 to
2d71aa2
Compare
2d71aa2 to
59d1866
Compare
1dded33 to
6f28879
Compare
6f28879 to
9f5b4dd
Compare
Integralist
commented
Oct 31, 2023
pkg/app/run.go
Outdated
Comment on lines
118
to
119
| // FIXME: We need the actual URL to point users to. | ||
| text.Important(g.Output, "The Fastly CLI is configured to collect data related to Wasm builds (e.g. compilation times, resource usage, and other non-identifying data). To learn more about what data is being collected, why, and how to disable it: https://www.fastly.com/") |
Collaborator
Author
There was a problem hiding this comment.
@jaskiratr we'll need an actual URL here (or should this be https://bit.ly/wasm-metadata which points to our community forum thread on the topic)?
There was a problem hiding this comment.
We'll update the CLI reference page with the information about what data is being collected, why, and how to disable it
27b1956 to
e35ebba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
fastly compute metadatacommand.It should only be merged after #1016 is merged.
Below are some screenshots highlighting how the new
compute metadatacommand works...Below is a screenshot highlighting the new
compute metadatamessaging for users who install the CLI for the first time or who upgrade to the CLI version that includes metadata collection...