feat(spinner): abstract common pattern #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
awilliams-fastly
left a comment
There was a problem hiding this comment.
Nice! This really removes a lot of boilerplate.
I reviewed the changes where the SpinnerWrapper is used, but mainly focused on the implementation. Left a few minor comments, but looking good in general.
91f8a5b to
7ba5b64
Compare
awilliams-fastly
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a common pattern used across the CLI where we...
It's very tedious and verbose/noisy code and makes reading the code quite hard at times.
So I've made an abstraction to try and reduce the noise.
The spinner abstraction can be seen in
pkg/text/spinner.go.