refactor(compute/deploy): simplify logic flows #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
214a9a1 to
5b7c30f
Compare
… + clean up ExistingServiceIDVersion()
5b7c30f to
02e9465
Compare
fgsch
approved these changes
Oct 12, 2023
Member
fgsch
left a comment
There was a problem hiding this comment.
I've been poking around but it's a big PR. Let's merge it now and do more testing in tree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEWER NOTE: Probably easier to avoid the diffs and to just read the actual code files.
I've both manually and programmatically validated the code still works (see screenshot for a single example):