Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Integralist
Copy link
Collaborator

@Integralist Integralist commented Oct 16, 2023

We support --env in compute serve, which acts as a switch for the fastly.toml manifest that is loaded.

For example, fastly compute serve --env stage will attempt to use a fastly.stage.toml manifest file.

Customers have requested the same support for --env with the compute deploy command.

This PR modifies the following compute commands because it made sense to add support for --env to them...

  • compute build
  • compute deploy
  • compute publish
  • compute hashsum
  • compute hash-files

I've manually tested these commands to ensure they're working as intended.

NOTE: The other reason for modifying hashsum and hash-files is that I realised if we support modifying a build to use --env then it means we need to be able to reproduce that build for the hashing commands.

@Integralist Integralist added the enhancement New feature or request label Oct 16, 2023
@Integralist Integralist requested a review from fgsch October 16, 2023 17:07
@Integralist Integralist force-pushed the integralist/deploy-support-env branch from 48d72e2 to 3be1e5b Compare October 16, 2023 17:13
@Integralist Integralist force-pushed the integralist/deploy-support-env branch from 4030b91 to 93b830e Compare October 17, 2023 10:31
Copy link
Contributor

@grantstephens grantstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments. One other thing: Should we always print the env if it is set just to make it very clear that it's set and we're reading it?

@Integralist Integralist merged commit ca0f97c into main Oct 18, 2023
@Integralist Integralist deleted the integralist/deploy-support-env branch October 18, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants