feat(compute/deploy): avoid store conflicts #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b497455 to
2cab334
Compare
c662e11 to
c10a50d
Compare
ed5c903 to
8f6eccb
Compare
Contributor
grantstephens
left a comment
There was a problem hiding this comment.
Couple of small comments, otherwise LGTM
8f6eccb to
53de04b
Compare
grantstephens
approved these changes
Oct 17, 2023
Contributor
grantstephens
left a comment
There was a problem hiding this comment.
Small, thing, but happy to defer to your judgement. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770 #973
Currently, if you try to use a starter kit more than once (for the same 'account') you might run into an issue where by the CLI will report a 409 Conflict when it tries to create a store. This PR fixes that by notifying the user and letting them choose whether they want to link to the existing store or choose a new store to be created (subsequently prompting the user to give a different store name).
You can see in the following screenshot that I use
--non-interactivemode, so the CLI will automatically opt for linking to the existing store.