Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(github): update wasm-tools path #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Integralist merged 2 commits into from
Feb 21, 2024
Merged

fix(github): update wasm-tools path #1136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc675d
fix(github): update wasm-tools path
Integralist Feb 20, 2024
12e6122
fix(docker): crates.io now returns 500 for search pattern
Integralist Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Dockerfile-rust
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ RUN rustup toolchain install ${RUST_TOOLCHAIN} \
&& useradd -ms /bin/bash fastly

USER fastly
# this forces the download of the crates index; it will save build time if the image was recently built
RUN cargo search --limit 0
Copy link
Collaborator Author

@Integralist Integralist Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated to the PR itself but was needed as crates.io now returns a 500 Internal Server Error for this call (I'm able to replicate locally). I've pinged our Rust experts internally about whether something changed on the Crates end of things, but as it's a performance operation and doesn't directly affect functionality I decided the best thing to do is to just remove the line.


WORKDIR /app
ENTRYPOINT ["/usr/bin/fastly"]
Expand Down
2 changes: 1 addition & 1 deletion pkg/github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ func (m Metadata) URL() string {
// NOTE: We use `m.repo` for wasm-tools instead of `m.binary`.
// This is because we append `.exe` to `m.binary` on Windows.
// Instead of filtering the extension we just use `m.repo` instead.
pattern := fmt.Sprintf("https://github.com/%s/%s/releases/download/%s-%s/%s-%s-%s-%s.%s", m.org, m.repo, m.repo, version, m.repo, version, arch, platform, extension)
pattern := fmt.Sprintf("https://github.com/%s/%s/releases/download/v%s/%s-%s-%s-%s.%s", m.org, m.repo, version, m.repo, version, arch, platform, extension)
if matched, _ := regexp.MatchString(pattern, a.BrowserDownloadURL); matched {
return a.BrowserDownloadURL
}
Expand Down