Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(app): update list of commands that require a token #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Integralist merged 2 commits into from
Mar 4, 2024
Merged

refactor(app): update list of commands that require a token #1145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8cdb3d
Update list of commands that require a token
fgsch Mar 3, 2024
0db383c
style: underscore unused argument
Integralist Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/app/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ func commandRequiresAuthServer(command string) bool {
// requires an API token.
func commandRequiresToken(command string) bool {
switch command {
case "compute init", "compute metadata", "compute serve":
case "compute build", "compute hash-files", "compute init", "compute metadata", "compute serve":
return false
}
command = strings.Split(command, " ")[0]
Expand Down
3 changes: 1 addition & 2 deletions pkg/commands/compute/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ func validStatusCodeRange(status int) bool {
// - Validate there is a package to deploy.
// - Determine if a trial needs to be activated on the user's account.
func (c *DeployCommand) Setup(out io.Writer) (fnActivateTrial Activator, serviceID string, err error) {
defaultActivator := func(customerID string) error { return nil }
defaultActivator := func(_ string) error { return nil }

token, s := c.Globals.Token()
if s == lookup.SourceUndefined {
Expand Down Expand Up @@ -462,7 +462,6 @@ func locateManifest(path, manifestFilename string) (string, error) {
}
return nil
})

if err != nil {
// If the error isn't ErrStopWalk, then the WalkDir() function had an
// issue processing the directory tree.
Expand Down