Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Integralist
Copy link
Collaborator

@Integralist Integralist commented Mar 8, 2024

Problem

A customer ran the compute serve command with a custom build script.

The build script produced a non-standard wasm binary filename.

i.e. the file location was not ./bin/main.wasm (which is the required naming format).

The CLI's build logic correctly returns an error to suggest that the custom build script did not produce a ./bin/main.wasm.

The problem is that the customer also had provided the --file flag to the compute serve command, which changes the viceroy binary invocation such that it will try to load a different wasm binary file. So the intention is very much for the filename of the provided wasm binary to be non-standard (as the default value for --file is ./bin/main.wasm).

Solution

Track whether the --file flag was passed to compute serve, and if so, skip any validation steps for the wasm binary as they are not required with regard to the local server behaviour.

@Integralist Integralist added the bug Something isn't working label Mar 8, 2024
@Integralist Integralist merged commit 9af091f into main Mar 11, 2024
@Integralist Integralist deleted the integralist/fix-serve-file branch March 11, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants