fix(compute/serve): avoid wasm validation when --file is set #1150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A customer ran the
compute servecommand with a custom build script.The build script produced a non-standard wasm binary filename.
i.e. the file location was not
./bin/main.wasm(which is the required naming format).The CLI's build logic correctly returns an error to suggest that the custom build script did not produce a
./bin/main.wasm.The problem is that the customer also had provided the
--fileflag to thecompute servecommand, which changes theviceroybinary invocation such that it will try to load a different wasm binary file. So the intention is very much for the filename of the provided wasm binary to be non-standard (as the default value for--fileis./bin/main.wasm).Solution
Track whether the
--fileflag was passed tocompute serve, and if so, skip any validation steps for the wasm binary as they are not required with regard to the local server behaviour.