fix(compute/rust) handling of 'cargo version' output #1197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'cargo version' emits the version string to stdout, so the code should capture only stdout, and parse it for checking the ToolchainConstraint. Capturing stderr and including it in the parsing process can result in bogus version numbers being found and reported (as is happening right now when Rust 1.78 is used in a project directory where .cargo/config exists).
Integralist
approved these changes
May 7, 2024
Collaborator
Integralist
left a comment
There was a problem hiding this comment.
LGTM. But can we manually test this change with different Rust/cargo versions to be sure there are no unexpected issues.
Contributor
Author
|
I'll be testing it with 1.78 (the version causing the problem now) and 1.56 (the oldest version we claim to support). |
Contributor
Author
|
Tests complete:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'cargo version' emits the version string to stdout, so the code should capture only stdout, and parse it for checking the ToolchainConstraint. Capturing stderr and including it in the parsing process can result in bogus version numbers being found and reported (as is happening right now when Rust 1.78 is used in a project directory where .cargo/config exists).