feat(compute/rust): Handle Cargo config filename for Rust >=1.78.0 #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
reviewed
May 8, 2024
Collaborator
Integralist
left a comment
There was a problem hiding this comment.
This isn't the end of the world but I would prefer not to have two WARNING lines next to each other when they both relate to the same warning.
I can see why that has happened by looking at the code and the fact you're trying to swap out the second warning for an error (depending on the situation) but it just looks a bit weird.
Integralist
reviewed
May 8, 2024
The preferred Cargo configuration filename has been 'config.toml' since Rust 1.39.0 was released, but 'config' was supported for backwards compatibility (although deprecated). In Rust 1.78.0, the backwards compatibility was removed, so any file with the old name will be ignored. Since Compute package builds require the content in that file, ignoring it results in a build failure. This patch adds checking for this situation. If the old file name is found, and the Rust version is <1.78.0, a warning is issued to let the user know that they should rename the file before upgrading to 1.78.0 or later. If the old file name is found, and the Rust version is >=1.78.0, an error is emitted and the build process stopped, as it will not succeed.
Contributor
Author
|
New output: and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preferred Cargo configuration filename has been 'config.toml' since Rust 1.39.0 was released, but 'config' was supported for backwards compatibility (although deprecated).
In Rust 1.78.0, the backwards compatibility was removed, so any file with the old name will be ignored. Since Compute package builds require the content in that file, ignoring it results in a build failure.
This patch adds checking for this situation. If the old file name is found, and the Rust version is <1.78.0, a warning is issued to let the user know that they should rename the file before upgrading to 1.78.0 or later. If the old file name is found, and the Rust version is >=1.78.0, an error is emitted and the build process stopped, as it will not succeed.
Example output (with old file name and Rust 1.74.0):
Example output (with old file name and Rust 1.78.0):