Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Integralist
Copy link
Collaborator

Fixes #1198

The compute build command was being invoked even when the user passed their own Wasm binary via compute serve --file <PATH/TO/WASM/BINARY>. This is unnecessary because if you're passing --file then you're indicating that you're not using the Fastly CLI to compile your code as you already have a binary to be used from elsewhere (whether that's an unsupported language like Zig or you have a completely separate build step).

I've modified the compute serve command to skip the compute build if --file is set, and I've also removed some older code where (for some reason) when we were running compute build (even though compute serve --file was set) we were passing through a flag to the compute build command to get it to skip validating the expected ./bin/main.wasm output, which isn't needed anymore if we just skip the build process entirely.

@Integralist Integralist added the bug Something isn't working label May 8, 2024
@Integralist Integralist requested a review from fgsch May 8, 2024 10:21
Copy link
Member

@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Integralist Integralist merged commit d145b2f into main May 8, 2024
@Integralist Integralist deleted the integralist/serve-file branch May 8, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--file option of fastly compute serve looks like it's ignored

3 participants