Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CDTOOL-895] - Support for Image Optimizer Settings #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rcaril merged 10 commits into from
Aug 18, 2025
Merged

[CDTOOL-895] - Support for Image Optimizer Settings #1518

rcaril merged 10 commits into from
Aug 18, 2025

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Aug 18, 2025 •
edited
Loading

All Submissions:

  • Have you followed the guidelines in our Contributing document?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

This PR implements support for retrieving and updating Image Optimizer defaults for a given VCL service .

@rcaril rcaril requested a review from a team as a code owner August 18, 2025 14:35
@rcaril
Copy link
Contributor Author

rcaril commented Aug 18, 2025

Tests:

 make test TEST_ARGS="-run TestImageOptimizerDefaultsGet ./pkg/commands/imageoptimizerdefaults/"
ok      github.com/fastly/cli/pkg/commands/imageoptimizerdefaults       1.059s

make test TEST_ARGS="-run TestImageOptimizerDefaultsUpdate ./pkg/commands/imageoptimizerdefaults/"
ok      github.com/fastly/cli/pkg/commands/imageoptimizerdefaults       1.081s

anthony-gomez-fastly
anthony-gomez-fastly approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcaril rcaril merged commit 9865b8b into main Aug 18, 2025
12 checks passed
@rcaril rcaril deleted the CDTOOL-895 branch August 18, 2025 15:33
@BrewTestBot BrewTestBot mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-gomez-fastly anthony-gomez-fastly anthony-gomez-fastly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rcaril @anthony-gomez-fastly