Ensure [local_server.pushpin] section persists during fastly.toml manifest file update #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaril
approved these changes
Sep 9, 2025
Contributor
rcaril
left a comment
There was a problem hiding this comment.
The changes looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
This PR updates
MarshalTOML()formanifest/Filesuch that the[local_server.pushpin]section and its fields persist when the file is written.pushpinsection as well as its individual fields are now optional, such that it will be able to persist the file back as it was before starting.[local_server.pushpin]has been added tofastly-viceroy-update.toml, which is used by the testTestManifestPersistsLocalServerSection, ensuring that the section is written out and reads back in to the same value.This fixes #1532.
Changes to Core Features:
User Impact
Users can now safely run CLI commands that modify fastly.toml without losing their
[local_server.pushpin]section.Are there any considerations that need to be addressed for release?
Since this overwrite happens right after initializing an app from the starter kit, this would be nice to get out asap.
Would be great if this can be released as a quick patch release such as 11.5.1.