Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@backkem
Copy link
Contributor

@backkem backkem commented Oct 20, 2025

Add "file not found" to the ErrReadingManifest error message to make it clearer that the file doesn't exist, rather than a parsing or permission error.

Change summary

The current error message "error reading fastly.toml" is somewhat ambiguous and doesn't clearly indicate whether the file is missing or has parsing errors. The remediation text was present but it still seems easy to misinterpret the actual problem (as proven by it managing to throw both me, Claude and ChatGPT off 😅).

This change adds ": file not found" to the error message to make it even more apparent that the file doesn't exist.

Before:
ERROR: error reading fastly.toml. Ensure the Fastly CLI is being run within a directory containing a fastly.toml
file...

After:
ERROR: error reading fastly.toml: file not found. Ensure the Fastly CLI is being run within a directory containing
a fastly.toml file...

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for
    the same update/change?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • Users will now more easily understand that the fastly.toml file is missing.

@backkem backkem requested a review from a team as a code owner October 20, 2025 09:39
@backkem backkem requested a review from rcaril October 20, 2025 09:39
Add "file not found" to the ErrReadingManifest error message to make it
clearer that the file doesn't exist, rather than a parsing or permission error.
@backkem backkem force-pushed the explicit-manifest-error branch from 145b929 to 41a9ff2 Compare October 20, 2025 09:41
@anthony-gomez-fastly anthony-gomez-fastly enabled auto-merge (squash) October 20, 2025 16:25
@anthony-gomez-fastly anthony-gomez-fastly merged commit c7b8baf into fastly:main Oct 20, 2025
9 checks passed
@backkem backkem deleted the explicit-manifest-error branch October 20, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants