feat(service-version): Add JSON support to service-version clone command #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of issue 1353, the service-version clone command is missing the option for JSON output and to use it in scripts the output need to be parsed. This commit adds functionality to accept the --json argument to the service-version clone command and outputs the appropriate format. Unit tests passing.
b5d87db to
16f3950
Compare
Contributor
|
The test failure on Windows is not related to the contents of this PR - that sort of 'race condition' failure happens sometimes on Windows but it hasn't been a priority for us to fix it. Feel free to just re-run the failing job and it will almost certainly succeed. |
kpfleming
requested changes
Oct 23, 2025
Contributor
kpfleming
left a comment
There was a problem hiding this comment.
Some small changes needed, but overall this looks very good!
e367d5e to
d6b139c
Compare
kpfleming
approved these changes
Nov 6, 2025
Contributor
|
Looks great, I'll merge it now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Added JSON support to service-version clone command as reported in issue #1353.
NOTE: Unable to reproduce the ordering issue/race condition that the customer reported by running the list command immediately after the clone command. We ran this sequence multiple times, but each time the list was returned in the expected order, with the newly cloned service-version listed last.
All Submissions:
Changes to Core Features:
User Impact
Are there any considerations that need to be addressed for release?
No breaking changes.