Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CDTOOL-1190 add support for CRUD operations for NGWAF workspaces #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anthony-gomez-fastly merged 9 commits into from
Nov 12, 2025
Merged

CDTOOL-1190 add support for CRUD operations for NGWAF workspaces #1570

anthony-gomez-fastly merged 9 commits into from
Nov 12, 2025

Conversation

@anthony-gomez-fastly
Copy link
Contributor

@anthony-gomez-fastly anthony-gomez-fastly commented Oct 30, 2025

Change summary

Add workspace CRUD operations for NGWAF Workspaces.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1190-ngwaf-workspaces branch from 50eebe1 to 223d8a2 Compare October 30, 2025 20:07
anthony-gomez-fastly
anthony-gomez-fastly commented Oct 30, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly commented Oct 30, 2025
View reviewed changes
anthony-gomez-fastly
anthony-gomez-fastly commented Oct 30, 2025
View reviewed changes
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review October 30, 2025 20:12
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner October 30, 2025 20:12
rcaril
rcaril previously requested changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@rcaril rcaril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, some minor suggestions / changes.

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1190-ngwaf-workspaces branch from b92801a to acad3c3 Compare November 10, 2025 15:38
rcaril
rcaril reviewed Nov 12, 2025
View reviewed changes
rcaril
rcaril approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@rcaril rcaril left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor item, but otherwise looks good to me.

@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1190-ngwaf-workspaces branch from ebd5e5b to f9d42f3 Compare November 12, 2025 20:16
@anthony-gomez-fastly anthony-gomez-fastly force-pushed the CDTOOL-1190-ngwaf-workspaces branch from f9d42f3 to 27e154e Compare November 12, 2025 20:17
@anthony-gomez-fastly anthony-gomez-fastly enabled auto-merge (squash) November 12, 2025 20:17
@anthony-gomez-fastly anthony-gomez-fastly merged commit 7d1ceff into main Nov 12, 2025
13 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the CDTOOL-1190-ngwaf-workspaces branch November 12, 2025 20:30
@BrewTestBot BrewTestBot mentioned this pull request Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rcaril rcaril rcaril approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anthony-gomez-fastly @rcaril