Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[CDTOOL-1221] Support for NGWAF Threshold Commands #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rcaril merged 5 commits into from
Dec 9, 2025
Merged

[CDTOOL-1221] Support for NGWAF Threshold Commands #1595

rcaril merged 5 commits into from
Dec 9, 2025

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Dec 9, 2025 •
edited
Loading

Change summary

This PR adds CRUD commands for the NGWAF Threshold feature to the CLI.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
make test TEST_ARGS="-run TestThresholdCreate ./pkg/commands/ngwaf/workspace/threshold"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/threshold    1.107s
make test TEST_ARGS="-run TestThresholdDelete ./pkg/commands/ngwaf/workspace/threshold"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/threshold    1.064s
make test TEST_ARGS="-run TestThresholdGet ./pkg/commands/ngwaf/workspace/threshold"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/threshold    1.055s
make test TEST_ARGS="-run TestThresholdList ./pkg/commands/ngwaf/workspace/threshold"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/threshold    1.064s
make test TEST_ARGS="-run TestThresholdUpdate ./pkg/commands/ngwaf/workspace/threshold"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/threshold    1.055s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@rcaril rcaril marked this pull request as ready for review December 9, 2025 16:38
@rcaril rcaril requested a review from a team as a code owner December 9, 2025 16:38
@rcaril rcaril requested a review from kpfleming December 9, 2025 16:38
kpfleming
kpfleming approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A couple of ideas which could be turned into Jira work items for future improvements to the code (but not the functionality).

@rcaril rcaril merged commit bae2377 into main Dec 9, 2025
13 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1221-ngwaf-thresholds-crud-support branch December 9, 2025 18:29
@BrewTestBot BrewTestBot mentioned this pull request Dec 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kpfleming kpfleming kpfleming approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rcaril @kpfleming