Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rcaril
Copy link
Contributor

@rcaril rcaril commented Dec 9, 2025

Change summary

This PR corrects a few commands that were missing a check which ensured the JSON and Verbose flags were not used simultaneously.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
make test TEST_ARGS="-run TestRedactionCreate ./pkg/commands/ngwaf/workspace/redaction"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/redaction    1.064s
make test TEST_ARGS="-run TestRedactionUpdate ./pkg/commands/ngwaf/workspace/redaction"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/redaction    1.056s
make test TEST_ARGS="-run TestVirtualPatchUpdate ./pkg/commands/ngwaf/workspace/virtualpatch"
ok      github.com/fastly/cli/pkg/commands/ngwaf/workspace/virtualpatch 1.089s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

  • What is the user impact of this change?

Are there any considerations that need to be addressed for release?

There isn't a direct end user impact, this fixes niche behavior should not have been allowed.

@rcaril rcaril marked this pull request as ready for review December 9, 2025 17:01
@rcaril rcaril requested a review from a team as a code owner December 9, 2025 17:01
@rcaril rcaril requested a review from philippschulte December 9, 2025 17:01
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rcaril rcaril merged commit 54f7046 into main Dec 9, 2025
13 checks passed
@rcaril rcaril deleted the rcaril/CDTOOL-1238-workspace-ErrInvalidVerboseJSONCombo-check branch December 9, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants