resource: Improve parameter naming; support JSON encode #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API documentation is inconsistent in the use of `resource_id`. This change departs from the API docs and consistently uses: * `resource_id`: ID of the linked to object, e.g. the Object Store ID * `id`: ID of the "resource", e.g. the Resource (link) ID The API docs will be updated accordingly. Additionaly, `json` tags have been added to the `Resource` type. This allows a `Resource` to be properly encoded as JSON.
Integralist
approved these changes
Feb 8, 2023
awilliams-fastly
added a commit
to fastly/cli
that referenced
this pull request
Feb 22, 2023
https://developer.fastly.com/reference/api/services/resource/ This adds a `resource-link` sub-command which has associated create, delete, list, and update commands. ``` USAGE fastly resource-link <command> [<args> ...] Manipulate Fastly service resource links COMMANDS resource-link create Create a Fastly service resource link delete Delete a resource link for a Fastly service version describe Show detailed information about a Fastly service resource link list List all resource links for a Fastly service version update Update a resource link for a Fastly service version SEE ALSO https://developer.fastly.com/reference/cli/resource-link/ ``` Related `go-fastly` change: fastly/go-fastly#394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API documentation is inconsistent in the use of
resource_id. This change departs from the API docs and consistently uses:resource_id: ID of the linked to object, e.g. the Object Store IDid: ID of the "resource", e.g. the Resource (link) IDThe API docs will be updated accordingly.
Additionaly,
jsontags have been added to theResourcetype. This allows aResourceto be properly encoded as JSON.