Add theta_map function and tests #561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the computation of the total horizontal derivative (THDR) of a potential field grid. This function calculates the square root of the sum of squares of the horizontal derivatives in the easting and northing directions.
Includes tests for: - Agreement with a synthetic model - Rejection of 1D and 3D grids - Handling of grids containing NaN values Ensures correctness and robustness of the total_horizontal_gradient filter.
Implements the theta map filter. The function computes the arctangent of the horizontal gradient magnitude over the total gradient amplitude. Includes a detailed docstring with formula and references.
Includes: - Validation against synthetic model using finite differences and FFT - Input error handling for 1D, 3D, and NaN-containing grids - Integration of theta_map import for test discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
theta_mapfunction toharmonica._transformations.The theta map is a commonly used edge-enhancement filter. It calculates the arctangent of the horizontal gradient magnitude divided by the total gradient amplitude.
Changes included in this PR:
theta_mapfunction with full docstring and mathematical formulaRelevant issues/PRs:
Closes #559
Continues work from #560