Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(manipulation): Allow any ParentNode as arg #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fb55 merged 1 commit into from
Nov 28, 2022
Merged

feat(manipulation): Allow any ParentNode as arg #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/manipulation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { ChildNode, Element } from "domhandler";
import type { ChildNode, ParentNode } from "domhandler";

/**
* Remove an element from the dom
Expand Down Expand Up @@ -46,17 +46,17 @@ export function replaceElement(elem: ChildNode, replacement: ChildNode): void {
* Append a child to an element.
*
* @category Manipulation
* @param elem The element to append to.
* @param parent The element to append to.
* @param child The element to be added as a child.
*/
export function appendChild(elem: Element, child: ChildNode): void {
export function appendChild(parent: ParentNode, child: ChildNode): void {
removeElement(child);

child.next = null;
child.parent = elem;
child.parent = parent;

if (elem.children.push(child) > 1) {
const sibling = elem.children[elem.children.length - 2];
if (parent.children.push(child) > 1) {
const sibling = parent.children[parent.children.length - 2];
sibling.next = child;
child.prev = sibling;
} else {
Expand Down Expand Up @@ -97,17 +97,17 @@ export function append(elem: ChildNode, next: ChildNode): void {
* Prepend a child to an element.
*
* @category Manipulation
* @param elem The element to prepend before.
* @param parent The element to prepend before.
* @param child The element to be added as a child.
*/
export function prependChild(elem: Element, child: ChildNode): void {
export function prependChild(parent: ParentNode, child: ChildNode): void {
removeElement(child);

child.parent = elem;
child.parent = parent;
child.prev = null;

if (elem.children.unshift(child) !== 1) {
const sibling = elem.children[1];
if (parent.children.unshift(child) !== 1) {
const sibling = parent.children[1];
sibling.prev = child;
child.next = sibling;
} else {
Expand Down