Fix recursion in findOne querying helper. Fixes #1856. #1857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@fb55, wanted to follow up on the status of this PR as this also fix an issue that we are experiencing in the Angular CLI. |
auto-merge was automatically disabled
January 6, 2025 18:51
Head branch was pushed to by a user without write access
Contributor
Author
Looks like it failed from a linting issue. Submitted a fix and also added a test for this scenario. |
Owner
|
Thanks @zachsents! Published as 3.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1856 for a detailed description of the issue. This fix works by only returning if the search down any particular recursion branch was successful.