fix: make d key wait for motion instead of deleting line immediately #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'd' key was mapped directly to DeleteLine in the editor keymap, causing it to delete the entire line on first press instead of waiting for a motion like 'dw' (delete word) or 'dd' (delete line). Changes: - Remove direct 'd' -> DeleteLine mapping from editor normal keymap - Add new d+motion commands: dh, dl, dj, dk, dG - Add corresponding c+motion commands: ch, cl, cj, ck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dkey in the query editor's vim mode - it was deleting the entire line immediately instead of waiting for a motiondwas mapped directly toDeleteLinein the keymap, bypassing the pending operator logic that handlesdw,dd,de, etc.dh,dl,dj,dk,dGch,cl,cj,ckTest plan
dwdeletes word forwarddedeletes to end of worddbdeletes word backwarddddeletes entire lined$deletes to end of lined0deletes to start of linedhdeletes character leftdldeletes character rightdjdeletes current line and line belowdkdeletes current line and line abovedGdeletes to end of file