crates/tsql/src/app/app.rs (4)

726-730: Consider keeping timer/throbber state co-located with DbSession (optional), but current wiring is fine.
Right now db.running lives in DbSession while query_start_time/throbber_state live in App. This works, but if you anticipate more “running UI” state, it may be cleaner to group them (or wrap into a small struct) to avoid drift.

Also applies to: 844-846

---

1254-1313: Guard overlay rendering for extremely small grid_area to avoid zero-area widget edge cases.
If the terminal is tiny, overlay_area/inner can end up with 0 height/width, and some widgets can behave oddly. Consider an early return like “only render overlay if grid_area.width >= 20 && grid_area.height >= 3” (or if inner.height >= 2).

-                if self.db.running {
+                if self.db.running && grid_area.width >= 20 && grid_area.height >= 3 {
                     // Calculate centered overlay area (40% width, minimum 20 chars, 5 lines height)
                     let overlay_width = (grid_area.width * 40 / 100).max(20).min(grid_area.width);
                     let overlay_height = 5u16.min(grid_area.height);
@@
-                    // Layout for spinner and elapsed time
+                    // Layout for spinner and elapsed time
                     let chunks = Layout::default()
                         .direction(Direction::Vertical)
                         .constraints([
                             Constraint::Length(1), // Spinner with label
                             Constraint::Length(1), // Elapsed time
                         ])
                         .split(inner);

---

4961-4964: Elapsed timer is only set for execute_query(); decide if meta queries / cell updates should also set it.
db.running becomes true in execute_meta_query() and execute_cell_update(), so the overlay shows, but elapsed time won’t (since query_start_time remains None). If the intent is “elapsed for any running operation”, set query_start_time = Some(Instant::now()) in those paths too.

Also applies to: 3277-3286, 3021-3028

---

5137-5140: Clear query_start_time on DbEvent::CellUpdated too (defensive consistency).
Today CellUpdated doesn’t set query_start_time, so it won’t leak, but clearing it there makes the state machine harder to accidentally break later (especially if you later add elapsed timing for updates).

             DbEvent::CellUpdated { row, col, value } => {
                 self.db.running = false;
+                self.query_start_time = None;
                 // Update the grid cell
                 if let Some(grid_row) = self.grid.rows.get_mut(row) {

Also applies to: 5181-5190, 5202-5211

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

crates/tsql/src/app/app.rs (2)

726-729: New App state looks fine; consider grouping spinner/timing state into a small struct.

Right now App is already very large; QueryRunUi { throbber_state, query_start_time } would keep this more maintainable without changing behavior.

Also applies to: 844-845

---

990-993: Tick-rate change achieves smooth animation, but consider making the idle redraw cheaper/configurable.

20 FPS redraw while idle (50ms) may be more CPU than needed for a mostly-static screen. If you want to keep it snappy, consider (a) increasing idle to ~100–200ms, or (b) only forcing redraws on state changes while idle.

Also applies to: 1654-1661

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.