backend: recognize Pulp format for RPM package URLs #3966
Conversation
|
Also, we will need to change our frontend config in ansible: index b380d7930d..627598f241 100644
--- a/roles/copr/frontend/templates/copr.conf
+++ b/roles/copr/frontend/templates/copr.conf
@@ -282,7 +282,8 @@ USAGE_TREEMAP_TEAMS = {
"Python-team": ["@python", "thrnciar", "torsava", "encukou", "cstratak", "churchyard"],
}
-PULP_CONTENT_URL = "{{ pulp_content_url }}"
+PULP_CONTENT_URL = '{{ backend_base_url }}/results/'
+
# OIDC config |
Pull Request validationFailed🔴 Review - Missing review from a member (2 required) Success🟢 CI - All checks have passed |
There was a problem hiding this comment.
I see this change is already on stage? ... so I guess this fix was not about the Repo downloads but about the Artchitectures install count? This seems like it's still not working :/ the repo downloads is correct for both chroots, but the install count is still 0 (https://copr.stg.fedoraproject.org/coprs/nikromen/xx/)
backend/copr_backend/hitcounter.py
Outdated
| repomd_url_regex = re.compile(base_regex + "repodata/repomd.xml", re.IGNORECASE) | ||
| rpm_url_regex = re.compile( | ||
| base_regex + r"(?P<build_dir>[^/]*)/(?P<rpm>[^/]*\.rpm)", re.IGNORECASE) | ||
| base_regex + r"(?:(?P<build_dir>[^/]*)/)?(?:Packages/(?P<subdir>[a-zA-Z])/)?(?P<rpm>[^/]*\.rpm)", |
There was a problem hiding this comment.
I have no idea what am I looking at :D
There was a problem hiding this comment.
I don't get why we need the non-matching groups ((?:) 🤷
There was a problem hiding this comment.
I think I would appreciate the "why?" question answered in the commit message, e.g. what URLs we were not matching before, and we do now ...
Otherwise, it's just a hit counter thing...
There was a problem hiding this comment.
The regex looks cleaner now
Deployed in production |
87d4df4 to
709a9f6
Compare
There was a problem hiding this comment.
OK the cronjob correctly updated the architectures downloads https://copr.stg.fedoraproject.org/coprs/nikromen/xx/
Fix #3502