feat(mason_logger): add interval to ProgressAnimation#1391
Merged
felangel merged 4 commits intofelangel:masterfrom Aug 17, 2024
Merged
feat(mason_logger): add interval to ProgressAnimation#1391felangel merged 4 commits intofelangel:masterfrom
interval to ProgressAnimation#1391felangel merged 4 commits intofelangel:masterfrom
Conversation
add new parameter to ProgressAnimation class to set the duration of changing between frames.
Contributor
Author
|
Video showing how the feature works VID-20240810-WA0041.mp4 |
interval to ProgressAnimation
felangel
approved these changes
Aug 17, 2024
Owner
felangel
left a comment
There was a problem hiding this comment.
LGTM thanks for the contribution! 💙
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Duration parameter to logger.progress() for customizable frame change speed
Status
Ready
Description
Added new parameter to the ProgressAnimation class to control the speed of changing
between frames because for me the default was so fast (80ms)
Type of Change