Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(flutter_bloc): remove context.watch from BlocConsumer #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

fix(flutter_bloc): remove context.watch from BlocConsumer #1916

merged 1 commit into from
Nov 11, 2020

Conversation

@felangel
Copy link
Owner

Status

READY

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package labels Nov 11, 2020
@felangel felangel requested a review from jorgecoca November 11, 2020 16:23
@felangel felangel self-assigned this Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020 •
edited
Loading

Codecov Report

Merging #1916 (5bca762) into master (dfea53a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1916    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           17         8     -9     
  Lines          291       137   -154     
==========================================
- Hits           291       137   -154
Impacted Files Coverage Δ
packages/flutter_bloc/lib/src/bloc_consumer.dart 100.00% <100.00%> (ø)
packages/bloc/lib/src/transition.dart
packages/bloc_test/lib/src/mock_bloc.dart
packages/bloc_test/lib/src/emits_exactly.dart
packages/bloc/lib/src/bloc_observer.dart
packages/bloc/lib/src/cubit.dart
packages/bloc/lib/src/change.dart
packages/bloc_test/lib/src/bloc_test.dart
packages/bloc_test/lib/src/when_listen.dart
packages/bloc/lib/src/bloc.dart

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f94d0b...5bca762. Read the comment docs.

@felangel felangel added the release candidate Candidate for release pending successful build label Nov 11, 2020
@felangel felangel merged commit 94c81e7 into master Nov 11, 2020
@felangel felangel deleted the fix/BlocConsumer-rebuilds branch November 11, 2020 17:12
@felangel felangel mentioned this pull request Nov 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgecoca jorgecoca jorgecoca approved these changes

Assignees

@felangel felangel

Labels

bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package release candidate Candidate for release pending successful build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Builder gets executed even if buildWhen is false

2 participants

@felangel @jorgecoca