Add support for passing ABI version to FFI.map_library_name.
#963
Conversation
|
cc @headius |
|
@larskanis what do you think about merging this? |
| end | ||
|
|
||
| def to_s | ||
| if root |
There was a problem hiding this comment.
I don't see much value to pass root through LibraryPath. It can be equally prepended externally.
There was a problem hiding this comment.
It's a more convenient interface:
e.g.
lib_path = __dir__ # or something
ffi_lib LibraryPath.new('vips', 42, lib_path)It's easier to understand the intention of the user (a library in a given path) and easier to print out/debug later on.
A lot of native libraries follow this pattern, i.e. compile a shared library into a known path.
In theory, if someone provides a value of "/foo/bar/mylib.so", that would be split into a root and a name. However, in that case, the string is just returned since there is no point to manipulate it further. Without root we couldn't represent such values.
| end | ||
| else | ||
| # Otherwise we just use a generic format: | ||
| "#{Platform::LIBPREFIX}#{name}.#{Platform::LIBSUFFIX}" |
There was a problem hiding this comment.
I would like to preserve the LIBSUFFIX-addition like so
lib = "#{Platform::LIBPREFIX}#{name}"
r = Platform::IS_WINDOWS || Platform::IS_MAC ? "\\.#{Platform::LIBSUFFIX}$" : "\\.so($|\\.[1234567890]+)"
lib += ".#{Platform::LIBSUFFIX}" unless lib =~ /#{r}/
libCommit c95b8f3 removed a possibly already present ABI version number.
Commit c95b8f3 removed a possibly already present ABI version number.
Fixes #728
cc @larskanis :)