Thanks to visit codestin.com
Credit goes to github.com

Skip to content

prioritize /opt/homebrew/lib (for macos on aarch64 only) for searching path #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dzprofessionerd wants to merge 1 commit into from
Closed

prioritize /opt/homebrew/lib (for macos on aarch64 only) for searching path #965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/ffi/library.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,12 @@ def ffi_lib(*names)
else
# TODO better library lookup logic
unless libname.start_with?("/") || FFI::Platform.windows?
path = ['/usr/lib/','/usr/local/lib/','/opt/local/lib/', '/opt/homebrew/lib/'].find do |pth|
path_candidates = if FFI::Platform::ARCH == 'aarch64' && FFI::Platform.mac?
['/opt/homebrew/lib/','/usr/lib/','/usr/local/lib/','/opt/local/lib/']
else
['/usr/lib/','/usr/local/lib/','/opt/local/lib/','/opt/homebrew/lib/']
Copy link
Collaborator

@eregon eregon Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove /opt/homebrew/lib/ from this list? That seems only useful on darwin-arm64.

Also could you add a space after every comma, or even better use %w[path1 path2]?

end
path = path_candidates.find do |pth|
File.exist?(pth + libname)
end
if path
Expand Down