Store functions in a hash rather than class variables #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting class variables will mutate the shape of the receiver, causing more inline cache polymorphism than necessary. Storing functions in a hash would better serve the intended functionality, and also benefit runtime performance
larskanis
requested changes
Feb 18, 2023
Member
larskanis
left a comment
There was a problem hiding this comment.
Hi Aaron! Tests fail with uninitialized constant LibTest::FFI_FUNCTIONS. Could you please fix this?
| * Stash the Function in a module variable so it does not get garbage collected | ||
| * Stash the Function in a hash so it does not get garbage collected | ||
| */ | ||
| snprintf(var, sizeof(var), "@@%s", StringValueCStr(name)); |
Member
There was a problem hiding this comment.
The var variable can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting class variables will mutate the shape of the receiver, causing more inline cache polymorphism than necessary. Storing functions in a hash would better serve the intended functionality, and also benefit runtime performance