MSVC Test Support #1028
Merged
MSVC Test Support #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…W when compiling with MSVC 22. These apis take a widechar - LPCWSTR. Thus these tests fail because Windows considers the pipe names to be invalid. Thus switch to the Ansi versions.
…Instead, the function pointers must be a typdef. For what its worth, see https://stackoverflow.com/a/37114318.
Member
|
Although I have less experience with cmake, I prefer a cross platform solution over separate branches. The test environments can usually be changed easily, so that introducing cmake should be simple. In addition the GitHub CI has mswin binaries for testing. Feel free to open a PR. |
Member
|
@cfis I just added a CI run on Github Actions for ffi on MSVC / MSWIN in #1092. For now
|
Contributor
Author
|
Awesome - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR includes several small changes that enable MSVC 2022 to compile the libtest library in the spec/fixtures directory. With these changes, all tests pass on MSVC.
Note that the compile.rb file on Windows only works with mingw, so it would have to change to support MSVC. I assume that isn't important, but if we wanted to go down that route at some point we could either: