Ensure GC-ing closures before fork - 2nd attempt #1125
Conversation
Fiddle::Closures can't be used before process is forked, otherwise test suite might crash with SELinux. This is similar treatment as is used in [Fiddle](ruby/fiddle@1343ac7). Fixes ffi#1120
a51da71 to
dc07b6e
Compare
|
So the CI passes now and it also works in Fedora including ppc64le / s390x. I am still afraid there might be some corner cases (e.g. running the test cases somehow in parallel) and therefore it would be better if there is less global state (e.g. the test lib is loaded separately for each test case). But I think this is step in right direction. |
|
This is OK to merge. But a last question: Is the issue in Fiddle specific to ppc64le or can it happen on x86_64 as well? |
The test suite as it is passes for me on x86_64 just fine as well as the test case from rhbz#2313598. Also Ruby test suite including Fiddle passes on x86_64 as well as on the ppc64le / s390x. But I am not expert in this area. Maybe there really is something missing in libffi 🤷 |
Fiddle::Closures can't be used before process is forked, otherwise test suite might crash with SELinux. This is similar treatment as is used in Fiddle.
Fixes #1120