Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@joshuay03
Copy link
Contributor

We're in the process of enabling Puma's preload_app! config at @buildkite. When auditing threads spawned during boot, Puma flagged this gem's callback dispatcher thread as potentially not fork safe. However, it appears to have been made fork safe in #1117.

This PR adds a :fork_safe thread variable that Puma uses to exclude threads from its safety reporting, so that anyone else auditing their threads this way won't see false positives from this gem.

Refs:

@joshuay03 joshuay03 moved this to In Progress / Pending Review in Open Source Jul 24, 2025
@joshuay03 joshuay03 force-pushed the mark-callback-dispatcher-thread-as-fork-safe branch from c4b770d to 0040b75 Compare September 23, 2025 10:41
@joshuay03 joshuay03 force-pushed the mark-callback-dispatcher-thread-as-fork-safe branch from 0040b75 to cdadc02 Compare September 23, 2025 10:56
@larskanis larskanis merged commit 3d5de90 into ffi:master Nov 3, 2025
1 check failed
@larskanis
Copy link
Member

Makes sense. Thank you!

@joshuay03 joshuay03 moved this from In Progress / Pending Review to Done in Open Source Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants