vvc_deblock.c: fix checkasm for one-sided chroma #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing an spatial_strong <= meant that the one-sided never ran properly.
SPATIAL_ACTIVITY (and CHROMA_DEBLOCK) had an ifdef that removed the one-sided calculation. This block of code as activated in the horizontal calculation and not the vertical, hence the one-sided failure. Since we don't need to ifdef this anymore (this was done for development purposes when implementing vertical), remove the extraneous parameter.
|
@nuomi2021 Should be good to go now, I forgot I had code that turned off the one-sided code path for vertical 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing an spatial_strong <= meant that the one-sided never ran properly.